Adjust buffer size instead of cpu-per-core #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out making many CPU cores working with a single ringbuf has a potential deadlock hazard, especially visible on RT kernels. To avoid even a slightest danger, reduce ringbuf size instead. In the new scenario if we do not fit into the total ringbuf size, the size of each individual ringbuf will be adjusted and aligned for readability.
Currently used int type is not enough when it comes to values like a few GiB, expressed in the number of bytes, making it impossible to set some reasonable values. Use long type for ROX_COLLECTOR_SINSP_BUFFER_SIZE, ROX_COLLECTOR_SINSP_TOTAL_BUFFER_SIZE, ROX_COLLECTOR_SINSP_THREAD_CACHE_SIZE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out making many CPU cores working with a single ringbuf has a potential deadlock hazard, especially visible on RT kernels. To avoid even a slightest danger, reduce ringbuf size instead. In the new scenario if we do not fit into the total ringbuf size, the size of each individual ringbuf will be adjusted and aligned for readability.
Checklist
Automated testing
Testing Performed
Manual testing.